|
Post by dshadoff on Nov 3, 2019 21:47:58 GMT
OK, let's not reopen old wounds. Discussion of the past is only helpful if people are trying to understand each other's perspectives in order to improve the situation; I'm not sure that's 100% happening here, so let's move on.
I think Uli should have called it 4.0 because: a) changes to axioms were made, and b) based on experience, nobody should trust that a x.0 version will be completely flawless. I think the fact that huge changes were taking place was clear from the release notes, but not everybody reads those.
elmer is doing everybody a favour by investing time into a version that has (apparently) been abandoned by its author, into which useful things were introduced. Let's be grateful for his efforts - he could easily consider it not worth his while and move on, and then where would we be ?
As for the issues which remain, nobody would be able to move forward without reproducible test cases and people willing to work together with a positive attitude to isolate issues and validate fixes. This is an absolute minimum, whether your'e talking about a commercial product, an internal application, or basement code.
|
|
|
Post by Arkhan on Nov 3, 2019 23:20:45 GMT
whoa whoa. I write at least half of this from a bedroom, not a basement.
I am trying to get Elmer to understand the perspective that contributed to the current things, though.
if DK can show his bankskip sound drop out issue, that would be good.
|
|
|
Post by theoldman on Nov 4, 2019 7:31:10 GMT
Elmer: Just checked, and confirmed that the timer irq works, and acts as expected, in 2019-11-01 version. Good Job!
Now, can you fix a typo for the next version? In Sound/sndDefs.h, line 90, PSGF_TEMPO should be $0A. That will 'fix' the psgTempo() function, so you can changed tempos 'on the fly' (ie,speed up the music as a timer counts down.)
Thx.
|
|
|
Post by DarkKobold on Nov 5, 2019 23:06:57 GMT
So, two banks are working as well. I'm not sure what my issue was that stopped me before, but it's working.
|
|
|
Post by dshadoff on Nov 5, 2019 23:11:54 GMT
Does this mean all of the (current) known issues are addressed ?
|
|
|
Post by DarkKobold on Nov 6, 2019 2:26:57 GMT
Does this mean all of the (current) known issues are addressed ? Or at least currently unreproducable.
|
|
|
Post by gredler on Nov 6, 2019 2:48:09 GMT
Thanks so much for everyone looking into this and discussing it! Hoping to get some sort of audio into there soon! DK was able to play some temporary tunes and SFX with Arkhan's direct support troubleshooting the whole mml2pce process and implementing the resulting files from that. The next step is to add some more specific sfx and music, and if we are able to reproduce we will be sure to raise the alarm. Thanks again!
|
|
|
Post by dshadoff on Nov 6, 2019 3:09:12 GMT
Awesome ! Next time you run into an issue you think is tool-based, it will be helpful to try to narrow it down to as simple a test case as possible in order to identify and fix the affected area of the toolset. The testcase will also be useful to verify that a fix works, and whether the issue returns after a modification (a “regression”).
|
|
|
Post by gredler on Nov 7, 2019 0:58:58 GMT
|
|
|
Post by DarkKobold on Nov 7, 2019 5:42:26 GMT
/*--------------------------------------------------------------------------------------*/ /* psgTempo() - wrapper for psg SetTempo function. */ /*--------------------------------------------------------------------------------------*/
psgTempo( amount ) int amount; { #asm
;----------------------------------------------------------------- ; Init function code. ;-----------------------------------------------------------------
lda #PSGF_TEMPO sta <__dh ; set function number ;----------------------------------------------------------------- ; get parameter off stack and save it ;----------------------------------------------------------------- ldy #0 lda [__stack],Y sta <__al
;----------------------------------------------------------------- ; ask bios to fade tracks. ;-----------------------------------------------------------------
jsr psg_bios #endasm }
This doesn't seem to do anything. Ark thinks it's due to a HuC change. I've tried calling it before and after psgPlay(TRACK_VACUUMBOSS);
|
|
|
Post by DarkKobold on Nov 7, 2019 5:43:44 GMT
Elmer: Just checked, and confirmed that the timer irq works, and acts as expected, in 2019-11-01 version. Good Job!
Now, can you fix a typo for the next version? In Sound/sndDefs.h, line 90, PSGF_TEMPO should be $0A. That will 'fix' the psgTempo() function, so you can changed tempos 'on the fly' (ie,speed up the music as a timer counts down.)
Thx.
Edit, found this, made the change, and psgTempo() still does not work.
Edit again - music actually has to play for a bit for it to work.
|
|
|
Post by theoldman on Nov 7, 2019 6:40:22 GMT
Elmer: Just checked, and confirmed that the timer irq works, and acts as expected, in 2019-11-01 version. Good Job!
Now, can you fix a typo for the next version? In Sound/sndDefs.h, line 90, PSGF_TEMPO should be $0A. That will 'fix' the psgTempo() function, so you can changed tempos 'on the fly' (ie,speed up the music as a timer counts down.)
Thx.
Edit, found this, made the change, and psgTempo() still does not work.
Edit again - music actually has to play for a bit for it to work.
It didn't work before because PSGF_TEMPO was defined as $10. I can't count in hex It does work now. Be careful, though. It is used to -change- the tempo on an already playing song (as you found out), and NOT to set an initial tempo. It is also not available for sub-tracks (ie, sound effects), and doesn't work for songs playing on v-sync.
What it actually does is make a psgBios call, that's all. It's the psgBios that handles the tempo change, by changing the timer time-out length. With that in mnd, you should probably also set the track delay to 0. You should be doing that anyway if you are using the timer.
Gredler: Those are the files I used to test the multi-song problem.
The 07-07 version of the new Huc, and squirrel3 with elmers mods. So you should be good to go.
I still need to test the cd/scd stuff, though.
|
|
|
Post by DarkKobold on Nov 7, 2019 6:51:37 GMT
With that in mnd, you should probably also set the track delay to 0. You should be doing that anyway if you are using the timer.
TBH, I have no idea what I'm doing. I call psgPlay, psgTempo, psgFadeOut, and psgAllStop.
That's about the extent of my understanding of what I'm doing.
|
|
|
Post by gredler on Nov 7, 2019 8:05:19 GMT
Thanks so much Old Man I appreciate your help!
Does anyone know how to slide a note up from one to another? When I try to & between notes they just stop and start, unless the two notes are the same.
|
|
|
Post by theoldman on Nov 7, 2019 9:03:18 GMT
Thanks so much Old Man I appreciate your help! Does anyone know how to slide a note up from one to another? When I try to & between notes they just stop and start, unless the two notes are the same. Sorry, That's the one most annoying thing missing from the bios player
If you feel adventurous, look into the sweep / sweep time operations. If you feel -really- adventurous, check out the pitch envelope stuff. If you find something that works well, post it here.
Yeah, the & is a tie; extends the length of matching note only. Don't blame us, we didn't write the player
|
|